Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2553): remove config with no properties + support metadata check for config without properties #2641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(#2553): remove config with no properties + support metadata check for config without properties #2641

wants to merge 1 commit into from
+154 −23

Conversation

matthieu-crouzet
Copy link
Contributor

Proposed change

  • Remove config with no properties
  • Support metadata check for config without properties

Related issues

@matthieu-crouzet matthieu-crouzet requested review from a team as code owners December 20, 2024 15:01
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 20, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 74f57c7.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 11m 16s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 1m 53s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 36s View ↗
nx run-many --target=build ✅ Succeeded 1m 53s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 19s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 34s View ↗
nx affected --target=test --cacheDirectory=/hom... ✅ Succeeded 41s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-06 13:44:10 UTC

cpaulve-1A
cpaulve-1A previously approved these changes Dec 20, 2024
View reviewed changes
sdo-1A
sdo-1A previously approved these changes Dec 20, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.34%. Comparing base (48e6670) to head (74f57c7).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...extractor/helpers/component/component.extractor.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthieu-crouzet matthieu-crouzet dismissed stale reviews from sdo-1A and cpaulve-1A via c44ac8f December 30, 2024 07:36
@matthieu-crouzet matthieu-crouzet force-pushed the fix/2553 branch 2 times, most recently from c44ac8f to b0291ff Compare December 30, 2024 08:39
kpanot
kpanot previously approved these changes Jan 6, 2025
View reviewed changes
@matthieu-crouzet matthieu-crouzet requested a review from a team January 6, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulve-1A cpaulve-1A cpaulve-1A approved these changes

@sdo-1A sdo-1A sdo-1A left review comments

@kpanot kpanot kpanot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working project:@ama-sdk/schematics project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/eslint-config project:@o3r/eslint-config-otter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: check-config-migration-metadata fails on specific case
4 participants
@matthieu-crouzet @kpanot @cpaulve-1A @sdo-1A